Skip to content

TUI enhancements#128

Merged
zanjonke merged 2 commits intomainfrom
feat/tui-enhancement
Mar 18, 2026
Merged

TUI enhancements#128
zanjonke merged 2 commits intomainfrom
feat/tui-enhancement

Conversation

@zanjonke
Copy link
Copy Markdown
Contributor

@zanjonke zanjonke commented Mar 13, 2026

TUI enhancements

This PR introduces TUI enhancements that address some of the feedback that we received during ***plain dev day 2026. It adds more observability to fixing and running unittests and conformance tests.

  • How many attempts have been made to fix one or the other?
  • Of what module are the conformance testes being ran / fixed?
  • What is the index of the current functional requirement?

Here are some screenshots (the actual specs and modules names are blurred out). What is new is in red squares.

Screenshot 2026-03-13 at 11 01 40 Screenshot 2026-03-13 at 11 12 47 Screenshot 2026-03-13 at 11 20 06

@zanjonke zanjonke self-assigned this Mar 13, 2026
@zanjonke zanjonke added the enhancement New feature or request label Mar 13, 2026
Copy link
Copy Markdown
Contributor

@pedjaradenkovic pedjaradenkovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From code perspective this looks OK, but I'll ask @dusano to take a look and share his thoughts from product side.

Personally, I'm not a big fan of printing out the attempt numbers as they can seem depressing to the users.

@pedjaradenkovic pedjaradenkovic requested a review from dusano March 13, 2026 17:27
@dusano
Copy link
Copy Markdown
Contributor

dusano commented Mar 14, 2026

  1. It's very helpful to see functionality number but I wouldn't have it as a separate line (also "Functional requirement" is wrong text). I suggest we do it like this:

Functionality 3: - :User: should be able to edit :Task:

That is, we add functionality number after "Functionality" text. This also saves precious space in TUI.

  1. Seeing module information is helpful when it's not the current module. In that case it's redundant. I would therefore show "of module..." only if it is a different module, not current.

  2. I also think that showing number of attemps is not particularly helpful (the user can't do anything about it) and it's potentially misleading (being mistaken for a progress bar).

I think showing just the elapsed time is the right approach. It communicates to the user that something is happening and also educates the user what is the normal duration of each step so that they can take action (ctrl+d) if something takes too long.

Therefore I'd like to ask to remove number of attempts from the UI.

@zanjonke
Copy link
Copy Markdown
Contributor Author

zanjonke commented Mar 14, 2026

Great points. Building on point 3 - would it make sense to add a timer for each state? That is to have timer for the Implementing the functionality, Unit tests, Refactoring and Conformance tests lines?

I wanted to iterate quickly on a specific frid and wanted to cancel it early if the Conformance tests state was taking too long - hence I introduced the attempts count and used it as a heuristic for that frid to cancel after eg. 5 attempts. Or if some previous frid was being fixed for more than a few times that I was not expecting it to be fixed I concluded I need to improve the specs of at least one fo those frids.

Same would be achievable if there was just a timer for the entire state (not just for the substate of running conformance tests for a specific frid). Maybe also a timer that persists when fixing conformance tests. WDYT?

@dusano
Copy link
Copy Markdown
Contributor

dusano commented Mar 14, 2026

Thanks for the suggestion but the entire TUI needs to be rethought so I wouldn't focus on it too much other than addressing the most obvious and important issues.

@zanjonke
Copy link
Copy Markdown
Contributor Author

Hey @dusano, just added the changes. Below are the screenshots of the TUI. Here are the changes.

  • of module is now shown only shown when a previous module is being processed
  • removed attempt counter for both unit and conformance testing attempts
  • moved the frid to the Functionality field
Screenshot 2026-03-16 at 15 03 10 Screenshot 2026-03-16 at 15 02 44 Screenshot 2026-03-16 at 15 03 29 Screenshot 2026-03-16 at 15 04 24

@dusano
Copy link
Copy Markdown
Contributor

dusano commented Mar 16, 2026

@zanjonke no further comments from me. This looks good and can be merged and deployed.

@zanjonke zanjonke merged commit e500c3a into main Mar 18, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants